fix: skip escrow orphan recovery under automated UI tests - #398
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the red `ui-regressions` job on main. Every app launch in a UI test run was opening with the previous launch's terminals as extra workspaces (2, then 10, then 20), so the close-window and close-workspace tests saw the wrong workspace count and the release never ran.
Each launch leaves its shells escrowed when the test kills it, and the next launch's orphan recovery revived them. Snapshot restore already skips automated runs; orphan recovery now follows the same rule (`SessionRestorePolicy.isRunningUnderAutomatedTests`, DEBUG only). Real users and the relaunch recovery socket test, which strips the UI test variables, are unaffected.
These tests were not failing because of a recent change. `ui-regressions` only started running them in 9255c64.
Two more tests in the same job were broken before this branch:
testCtrlDAfterClosingBottomRowIn2x2KeepsWorkspaceOpen: its harness asked for a fifth pane, over the four-pane limit, so setup always failed. It now reuses the existing right column.CloseWindowConfirmDialogUITestsis removed. It asserted that closing a window keeps its shell running for reopen. Closing a window now confirms and then frees its sessions, andWindowCloseConfirmCancelUITestscovers that.Test plan